Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter code extracting naming convention in combine_psm_fractions #2

Open
baynec2 opened this issue Jul 5, 2022 · 3 comments
Open

Comments

@baynec2
Copy link
Owner

baynec2 commented Jul 5, 2022

Right now the function works by splitting the file name by _ into the sample name and fraction. We will also want to retain the DG number. Need to update both the code and lab naming conventions to work appropriately. Will need to think some more about the best way to do this.

@c6sanche
Copy link

c6sanche commented Jul 8, 2022

Maybe think of splitting it my the File ID column instead? I think sometimes it changes often with each PD version

@baynec2
Copy link
Owner Author

baynec2 commented Jul 12, 2022

Do you know how the FileID column works? Does F1.9 mean Plex1.fraction9? If you had three plexes would it be F1.1-12, F2.1-12, and F3.1-12?

@c6sanche
Copy link

Yup that's how it works right now. It based on how we load our data into Proteome Discoverer when setting up a search though. So people would have to pay careful attention to load their first plex as F1, there second as F2, etc so that it's not confusing after the fact when you are trying to assign your columns to the correct samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants