Cannot set Gameboy colorization to "GBC"

[mechevarria]

Batocera build version

40 2024/08/01 01:28

Your architecture

X86_64

Your Graphic Processor Unit(s) (GPU)

Nvidia GeForce RTX 3060

Issue description

In the colorization options for Gameboy, there is no option to set the gambatte colorization to GBC and no way to save an override in retroarch. This options sets a game specific color palette -> https://docs.libretro.com/library/gambatte/
The current GBC options hard code a specific color like GBC - Blue and do not allow the lookup of a game specific color
If you manually set the colorization to GBC in retroarch settings and attempt to save an override, the configuration is written over by the config generator

Detailed reproduction steps

Launch a Gameboy game with gambatte core, a good example is 'Bionic Commando'. The default color goes to green, but if you select the core option colorization of 'GBC' the game gets specific colorization. There is no way to persist this config currently in Batocera

Details of any attempts to fix this yourself

The current workaround is to manually edit libretroOptions.py generator to include an option to set coreSettings.save('gambatte_gb_colorization', ‘”GBC”’) manually instead of the default coreSettings.save('gambatte_gb_colorization', '"internal"')

Details of any modifications you have made to Batocera.

None. Fresh install of Batocera 40 and deleted and regenerated the system folder

Logs and data

No response

[mechevarria]

I would change the elif option for GB - SmartColor to GB - Auto
coreSettings.save('gambatte_gb_colorization', ‘”auto”’) and add a second option GBC with a value set of coreSettings.save('gambatte_gb_colorization', ‘”GBC”’)

[Tovarichtch]

I reproduce. I think it's just outdated. It needs updating. I'll see what I can do.