Fix segfault caused by non-null-terminated string. #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got the printf %.*s idea from xcb documentation somewhere but now I can't find it. Fixes baskerville#1503
|
This looks correct. For reference to the printf field width specifier, I found it in xcb_get_property_reply.3. If my memory serves me right, the xcb_icccm stuff are mainly wrappers around the xcb property and atom interface. The manual page mentions using the xcb_get_property_value* accessors, but this is actually done by xcb_icccm_get_wm_name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the printf %.*s idea from xcb documentation somewhere but now I can't find it.
Fixes #1503
Hopefully this is the only case. I searched for
xcb_in the source and gave the results a cursory look.