Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "withMaxRows" and deprecate "withNumRows" on Search.Builder class [JIRA: CLIENTS-966] #169

Open
kuy opened this issue Aug 24, 2016 · 0 comments
Open

Add "withMaxRows" and deprecate "withNumRows" on Search.Builder class [JIRA: CLIENTS-966] #169

kuy opened this issue Aug 24, 2016 · 0 comments
Labels
JIRA: To Do
Milestone
riak-nodejs-clien...

Comments

@kuy
Copy link

kuy commented Aug 24, 2016

Search.Builder class has withNumRows method, but a parameter name is maxRows. I confused this mismatch of naming rule.
Is there any reason about leaving this mismatch?
@Basho-JIRA Basho-JIRA changed the title Add "withMaxRows" and deprecate "withNumRows" on Search.Builder class Add "withMaxRows" and deprecate "withNumRows" on Search.Builder class [JIRA: CLIENTS-966] Aug 24, 2016
@lukebakken lukebakken self-assigned this Aug 29, 2016
@lukebakken lukebakken added this to the riak-nodejs-client-2.3.0 milestone Aug 29, 2016
@lukebakken lukebakken modified the milestone: riak-nodejs-client-2.5.0 Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JIRA: To Do
Projects
None yet
Milestone
riak-nodejs-client-3.0.0
Development

No branches or pull requests
3 participants
@kuy @lukebakken @Basho-JIRA