Skip to content

Commit 6caa653

Browse files
committed
consider new rdkit PhysChem descriptors
1 parent 335b2e3 commit 6caa653

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

tests/test_elements/test_error_handling.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def test_dummy_fill_physchem_record_molpipeline(self) -> None:
142142
out = pipeline.transform(TEST_SMILES)
143143
out2 = pipeline2.fit_transform(TEST_SMILES)
144144
self.assertEqual(out.shape, out2.shape)
145-
self.assertEqual(out.shape, (3, 208))
145+
self.assertEqual(out.shape, (3, 215))
146146
self.assertTrue(np.nanmax(np.abs(out - out2)) < 0.000001)
147147

148148
def test_replace_mixed_datatypes(self) -> None:

tests/test_elements/test_mol2any/test_mol2rdkit_phys_chem.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,13 @@ def test_descriptor_list(self) -> None:
234234
"fr_thiophene",
235235
"fr_unbrch_alkane",
236236
"fr_urea",
237+
'NumUnspecifiedAtomStereoCenters',
238+
'NumBridgeheadAtoms',
239+
'NumAmideBonds',
240+
'NumHeterocycles',
241+
'NumAtomStereoCenters',
242+
'Phi',
243+
'NumSpiroAtoms',
237244
}
238245
self.assertSetEqual(expected_descriptors, set(DEFAULT_DESCRIPTORS))
239246

0 commit comments

Comments
 (0)