Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in transliteration of Greek #53

Open
arainboldt opened this issue Dec 10, 2019 · 2 comments
Open

Error in transliteration of Greek #53

arainboldt opened this issue Dec 10, 2019 · 2 comments
Labels

Comments

@arainboldt
Copy link

Hi!

Interesting project! It looks like the package is using the keyboard characters for transliteration. With Greek, however, the greek keyboard doesn't correspond to the english keyboard phonetically. The character θ for example is pronounced 'th' while it is on the 'u' key. It would be worth looking into setting up a more strict phonetic transliteration. Doing so with complex phonetic languages like french would be fun ;)

Andreas

@barseghyanartur
Copy link
Owner

barseghyanartur commented Dec 14, 2019

Hello Andreas.

Thanks for bringing this up.

There have been numerous attempts and PRs to bring corectness to Greek transliteration.

I'm all open for correctness and thus willing to accept a valid PR.

I think back in the day, I have used this Wikipedia article as a valid and trustworthy source of information on the topic.

Could you please double check your findings with the mentioned Wikipedia article and let me know if current interpretation of transliterate isn't correct?

Thank you!

@arainboldt
Copy link
Author

Hi,

Thanks for following up. The wiki article is generally correct, likely good enough for most purposes. It looks like the current packages is following it. I was thrown off by docs, which contains the referenced error:

Transliteration to Greek

print(translit(text, 'el'))

# Λορεμ ιψθμ δολορ σιτ αμετ

Which should read: Λορεμ ιψυμ δολορ σιτ αμετ

Cheers,

Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants