Remove the "oy" pre processor mapping for greek #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"ου" in both ISO 843[1], the international ratification of ELOT 743 v1 with a couple of minor differences, and ELOT 743 version 2 type 1 [2] (the Greek cross ratification of ISO 843 to adopt the above minor differences) specifically set an exception for the double vowel "ου", which needs to be transliterated as "ou" and vice versa. There is no mapping exception to/from "oy", so while "oy" would be transliterated, per the general rules, to "ου" the inverse would never be true in a transliteration context. It's important to note that nor the UN nor the ALA-LC (library of congress) treat "ου" differently than ISO-843/ELOT 743 v2 (which isn't the case for some other mappings). This closes barseghyanartur#47 Signed-off-by: Alexandros Kosiaris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"ου" in both ISO 843[1], the international ratification of ELOT 743 v1
with a couple of minor differences, and ELOT 743 version 2 type 1 [2]
(the Greek cross ratification of ISO 843 to adopt the above minor
differences) specifically set an exception for the double vowel "ου",
which needs to be transliterated as "ou" and vice versa. There is no
mapping exception to/from "oy", so while "oy" would be transliterated,
per the general rules, to "ου" the inverse would never be true in a
transliteration context.
It's important to note that nor the UN nor the ALA-LC
(library of congress) treat "ου" differently than ISO-843/ELOT 743 v2
(which isn't the case for some other mappings).
This closes #47
Signed-off-by: Alexandros Kosiaris [email protected]