Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values that fail validation are being stored as translation candidates (when not excluding validation group) #462

Open
NaLogo opened this issue Oct 8, 2024 · 0 comments

Comments

@NaLogo
Copy link

NaLogo commented Oct 8, 2024

Hello!

When the validation group is not excluded from laravel-translation-manager, user input that fails validation will be added to the ltm_translations table. That input may contain confidential or otherwise privacy-related data like passwords, email addresses, etc.

While excluding the validation group is a valid workaround, it does come with its own downsides in terms of usability, as it will no longer be possible to edit or add to the standard validation group via the Translation Manager frontend.

Since I am not sure what an acceptable solution would look like (I would've otherwise developed something and opened a PR), I'm raising this issue and asking for input.

Unfortunately, the values are not namespaced, so - would skipping missingKey() in Manager.php for keys with the format "validation.values.*" be acceptable?
This could be tied to an additional config setting, if desired.

If you don't consider this an issue at all and you would not accept any PRs for this anyway, then I'll accept that, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant