From 2151a02cd360f5a79fd9dab0cabe8a1fb764f789 Mon Sep 17 00:00:00 2001 From: erikn69 Date: Wed, 6 Mar 2024 12:18:54 -0500 Subject: [PATCH 1/2] Show an estimate of cache size on CacheCollector --- src/DataCollector/CacheCollector.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/DataCollector/CacheCollector.php b/src/DataCollector/CacheCollector.php index 19d0a3a12..1beed654b 100644 --- a/src/DataCollector/CacheCollector.php +++ b/src/DataCollector/CacheCollector.php @@ -38,6 +38,16 @@ public function onCacheEvent(CacheEvent $event) $label = $this->classMap[$class]; if (isset($params['value'])) { + if (is_string($params['value'])) { + $params['size'] = strlen($params['value']); + } else { + $params['size'] = strlen(serialize($params['value'])); + } + + if (isset($params['size'])) { + $params['size'] = $this->getDataFormatter()->formatBytes($params['size'] * 8); + } + if ($this->collectValues) { $params['value'] = htmlspecialchars($this->getDataFormatter()->formatVar($event->value)); } else { From 196cd978cfa20e087ed9a45723ee54573c8be70d Mon Sep 17 00:00:00 2001 From: erikn69 Date: Thu, 7 Mar 2024 10:03:28 -0500 Subject: [PATCH 2/2] CacheCollector CS Fix --- src/DataCollector/CacheCollector.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DataCollector/CacheCollector.php b/src/DataCollector/CacheCollector.php index 1beed654b..5240743f6 100644 --- a/src/DataCollector/CacheCollector.php +++ b/src/DataCollector/CacheCollector.php @@ -25,7 +25,7 @@ class CacheCollector extends TimeDataCollector public function __construct($requestStartTime, $collectValues) { - parent::__construct(); + parent::__construct($requestStartTime); $this->collectValues = $collectValues; } @@ -70,7 +70,7 @@ public function onCacheEvent(CacheEvent $event) public function subscribe(Dispatcher $dispatcher) { - foreach ($this->classMap as $eventClass => $type) { + foreach (array_keys($this->classMap) as $eventClass) { $dispatcher->listen($eventClass, [$this, 'onCacheEvent']); } }