Skip to content

Commit eb0c420

Browse files
authored
Use native sprintf.
1 parent ba4f036 commit eb0c420

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/SimpleDiff.php

+9-9
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,20 @@ public function compare(string $left, string $right, bool $strict = false): Diff
2424
for ($i = 0; isset($from[$i]); $i++) {
2525
$original = $from[$i];
2626
$target = $to[$i] ?? '';
27-
$lineNumber = str_pad((string) ($i + 1), $padLength, ' ', STR_PAD_LEFT) . '| ';
27+
$lineNumber = sprintf('%s| ', str_pad((string) ($i + 1), $padLength, ' ', STR_PAD_LEFT));
2828
if ($original === $target) {
2929
if ($captureBuffer !== []) {
30-
foreach ($captureBuffer as $captureType => $captureLines) {
30+
foreach ($captureBuffer as $captureLines) {
3131
foreach ($captureLines as $captureLine) {
3232
$return[] = $captureLine;
3333
}
3434
}
3535
$captureBuffer = [];
3636
}
37-
$return[] = ' ' . $lineNumber . $original;
37+
$return[] = sprintf(' %d%s', $lineNumber, $original);
3838
} else {
39-
$captureBuffer['-'][] = '- ' . $lineNumber . $this->prettyRender($original);
40-
$captureBuffer['+'][] = '+ ' . $lineNumber . $this->prettyRender($target);
39+
$captureBuffer['-'][] = sprintf('- %d%s', $lineNumber, $this->prettyRender($original));
40+
$captureBuffer['+'][] = sprintf('+ %d%s', $lineNumber, $this->prettyRender($target));
4141
$changedLines[] = $i + 1;
4242
}
4343
}
@@ -51,15 +51,15 @@ public function renderDiff(Diff|string $diff): string
5151
$return = [];
5252
foreach (explode("\n", is_string($diff) ? $diff : $diff->getDiff()) as $line) {
5353
if (($line[0] ?? '') === '+') {
54-
$return[] = '<div style="background:#a2f19c">' . htmlspecialchars($line) . '</div>';
54+
$return[] = sprintf('<div style="background:#a2f19c">%s</div>', htmlspecialchars($line));
5555
} elseif (($line[0] ?? '') === '-') {
56-
$return[] = '<div style="background:#e7acac">' . htmlspecialchars($line) . '</div>';
56+
$return[] = sprintf('<div style="background:#e7acac">%s</div>', htmlspecialchars($line));
5757
} else {
58-
$return[] = '<div>' . htmlspecialchars($line) . '</div>';
58+
$return[] = sprintf('<div>%s</div>', htmlspecialchars($line));
5959
}
6060
}
6161

62-
return '<pre class="code">' . implode("\n", $return) . '</pre>';
62+
return sprintf('<pre class="code">%s</pre>', implode("\n", $return));
6363
}
6464

6565

0 commit comments

Comments
 (0)