Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use banzai token and banzai URL on any cli command. #305

Open
pbalogh-sa opened this issue Sep 18, 2020 · 2 comments
Open

Ability to use banzai token and banzai URL on any cli command. #305

pbalogh-sa opened this issue Sep 18, 2020 · 2 comments

Comments

@pbalogh-sa
Copy link
Member

pbalogh-sa commented Sep 18, 2020

Is your feature request related to a problem? Please describe.
It would be useful if we could pass the token and the URL to any banzi-cli command.

Describe the solution you'd like to see
Ability to pass token and URL as command-line option similar to the banzai login command.
It would be great if we could get them from the environment variable as well.

@pbalogh-sa pbalogh-sa mentioned this issue Sep 18, 2020
2 tasks
@orymate
Copy link
Contributor

orymate commented Sep 18, 2020

I'd implement the env var only. It'd be inconsistent when banzai login would write these to the config while all other commands handle it just like a config.

@hiroshui
Copy link

I wouldn't implement it for every command. That's not a best practice for cli-based tools imho. I really like the idea of using it only via the config which will be generated by a login-cmd and with an env var mode which overrides the config values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants