helm chart v1.22.4 breaks upgrades due to additional matchLabels added

[joemiller]

Preflight Checklist

• I have searched the issue tracker for an issue that matches the one I want to file, without success.
• I am not looking for support or already pursued the available support channels without success.
• I agree to follow the Code of Conduct.

Operator Version

1.22.4

Installation Type

Official Helm chart

Bank-Vaults Version

No response

Kubernetes Version

1.30.0

Kubernetes Distribution/Provisioner

GKE, EKS

Expected Behavior

Upgrading the helm chart should succeed.

Actual Behavior

Using ArgoCD, when attempting to upgrade the helm chart from 1.22.3 -> 1.22.4, the deployment update is rejected because a new label was added and hardcoded into the deployment.yaml template:

Failed sync attempt to 57acc1b15547b561f72d2ba9a46061f4f889f331: one or more objects failed to apply, reason: error when patching "/dev/shm/300371924": Deployment.apps "vault-operator" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/instance":"vault-operator", "app.kubernetes.io/name":"vault-operator"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable (retried 5 times).

app.kubernetes.io/instance added in 2bd7c7d#diff-9740ffbfce1675e80ab604e95ffa60ef0c21f28db348b2dd2e0f38da341b4a02R20

Steps To Reproduce

1. upgrade an vault-operator instance installed via the official helm chart from 1.22.3 to 1.22.4

Configuration

n/a

Logs

n/a

Additional Information

No response