Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature branch: Transactions and alerts #2037

Closed
wants to merge 93 commits into from
Closed

Feature branch: Transactions and alerts #2037

wants to merge 93 commits into from

Conversation

alonp99
Copy link
Collaborator

@alonp99 alonp99 commented Jan 31, 2024

Description

Elaborate on the subject, motivation, and context.

Related issues

  • Provide a link to each related issue.

Breaking changes

  • Describe the breaking changes that this pull request introduces.

How these changes were tested

  • Describe the tests that you ran to verify your changes, including devices, operating systems, browsers and versions.

Examples and references

  • Links, screenshots, and other resources related to this change.

Checklist

  • [] I have read the contribution guidelines of this project
  • [] I have read the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings and errors
  • [] New and existing tests pass locally with my changes

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 6f00953

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

liorzblrn and others added 19 commits February 19, 2024 22:33
* fix: swagger

* fix: revert

* fix: eslint

---------

Co-authored-by: Lior Zamir <[email protected]>
* feat(*): the transactions drawer no longer uses hardcoded heading and summary

* feat(backoffice-v2): added counterparty id to search query params

* refactor(backoffice-v2): removed alert-definitions domain and moved logic to alerts domain

* feat(backoffice-v2): added loading state to heading and summary

* feat(backoffice-v2): added fallback state to alerts drawer

* refactor(seed.ts): updated seed to alternative between business and counterparty id

* revert(*): reverted counterparty id changes

* fix(*): fixed changes that broke from conflicts

* refactor(workflows-service): added optional chaining

* fix(workflows-service): lint error
* fix(backoffice-v2): fixed filters in state but not in the url reaching the backend

* refactor(backoffice-v2): removed console.log

* revert(backoffice-v2): removed assignee default filter

* fix(backoffice-v2): fixed key warning on navbar

* fix(*): lockfile fix
* refactor(*): updated instances of alert state

* refactor(backoffice-v2): updated toast text

* refactor(backoffice-v2): simplified pattern matching for decision

* refactor(workflows-service): addressed pr comment

* fix(workflows-service): fixed return of function
@liorzam liorzam changed the title Transactions and alerts Feature branch: Transactions and alerts Feb 29, 2024
…chema to support filtering by alert type

fix(TransactionMonitoringAlertsAnalysis.page.tsx): add key prop to AlertAnalysisSheet component to force re-render when alertId changes
fix(useTransactionMonitoringAlertsAnalysisPageLogic.tsx): remove duplicate navigateBack() call in useEffect hook
fix(schema.prisma): fix indentation and rename underReview enum value to under_review for consistency
fix(alert.service.ts): fix mapping of under_review enum value to pending status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants