Skip to content

Commit 3b32e39

Browse files
Make social links clickable + Hide “ads” section BAL-3220 (#2907)
* chore: hide ads sections; add href attribute to anchor-if-url component * chore: release version --------- Co-authored-by: Tomer Shvadron <[email protected]>
1 parent 19fcf9f commit 3b32e39

File tree

9 files changed

+44
-24
lines changed

9 files changed

+44
-24
lines changed

apps/kyb-app/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# kyb-app
22

3+
## 0.3.95
4+
5+
### Patch Changes
6+
7+
- Updated dependencies
8+
- @ballerine/ui@0.5.52
9+
310
## 0.3.94
411

512
### Patch Changes

apps/kyb-app/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@ballerine/kyb-app",
33
"private": true,
4-
"version": "0.3.94",
4+
"version": "0.3.95",
55
"type": "module",
66
"scripts": {
77
"dev": "vite",
@@ -17,7 +17,7 @@
1717
"dependencies": {
1818
"@ballerine/blocks": "0.2.30",
1919
"@ballerine/common": "^0.9.59",
20-
"@ballerine/ui": "0.5.51",
20+
"@ballerine/ui": "0.5.52",
2121
"@ballerine/workflow-browser-sdk": "0.6.78",
2222
"@lukemorales/query-key-factory": "^1.0.3",
2323
"@radix-ui/react-icons": "^1.3.0",

packages/react-pdf-toolkit/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# @ballerine/react-pdf-toolkit
22

3+
## 1.2.52
4+
5+
### Patch Changes
6+
7+
- Updated dependencies
8+
- @ballerine/ui@0.5.52
9+
310
## 1.2.51
411

512
### Patch Changes

packages/react-pdf-toolkit/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@ballerine/react-pdf-toolkit",
33
"private": false,
4-
"version": "1.2.51",
4+
"version": "1.2.52",
55
"types": "./dist/build.d.ts",
66
"main": "./dist/react-pdf-toolkit.js",
77
"module": "./dist/react-pdf-toolkit.mjs",
@@ -27,7 +27,7 @@
2727
},
2828
"dependencies": {
2929
"@ballerine/config": "^1.1.28",
30-
"@ballerine/ui": "0.5.51",
30+
"@ballerine/ui": "0.5.52",
3131
"@react-pdf/renderer": "^3.1.14",
3232
"@sinclair/typebox": "^0.31.7",
3333
"ajv": "^8.12.0",

packages/ui/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# @ballerine/ui
22

3+
## 0.5.52
4+
5+
### Patch Changes
6+
7+
- add href attribute to anchor-if-url component
8+
39
## 0.5.51
410

511
### Patch Changes

packages/ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@ballerine/ui",
33
"private": false,
4-
"version": "0.5.51",
4+
"version": "0.5.52",
55
"type": "module",
66
"main": "dist/index.js",
77
"types": "dist/index.d.ts",

packages/ui/src/components/atoms/AnchorIfUrl/AnchorIfUrl.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const AnchorIfUrl: TAnchorIfUrl = forwardRef(
2121

2222
if (checkIsUrl(children)) {
2323
return (
24-
<BallerineLink ref={ref} {...props}>
24+
<BallerineLink ref={ref} href={children} {...props}>
2525
{children}
2626
</BallerineLink>
2727
);

packages/ui/src/components/templates/report/components/AdsAndSocialMedia/AdsAndSocialMedia.tsx

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import React, { FunctionComponent } from 'react';
22
import { Card, CardContent, CardHeader } from '@/components';
33
import { TextWithNAFallback } from '@/components/atoms/TextWithNAFallback';
44
import { ctw } from '@/common';
5-
import { AdExample } from '../AdExample';
65
import { AdImageWithLink } from '../AdImageWithLink';
76
import { toTitleCase } from 'string-ts';
87
import { AnchorIfUrl } from '@/components/atoms/AnchorIfUrl';
@@ -87,18 +86,19 @@ export const AdsAndSocialMedia: FunctionComponent<{
8786
</div>
8887
</CardContent>
8988
</Card>
90-
<Card>
91-
<CardHeader className={'pt-4 font-bold'}>Related Ads</CardHeader>
92-
<CardContent className={'flex flex-col space-y-4'}>
93-
<div className={'grid grid-cols-[400px_400px] gap-8'}>
94-
{!!relatedAdsImages?.length &&
95-
relatedAdsImages.map(({ src, link }, index) => (
96-
<AdExample key={src} src={src} link={link} alt={`Ad Example ${index + 1}`} />
97-
))}
98-
{!relatedAdsImages?.length && <>No ads detected.</>}
99-
</div>
100-
</CardContent>
101-
</Card>
89+
{/*Hiding this for now, will be added back in later*/}
90+
{/*<Card>*/}
91+
{/* <CardHeader className={'pt-4 font-bold'}>Related Ads</CardHeader>*/}
92+
{/* <CardContent className={'flex flex-col space-y-4'}>*/}
93+
{/* <div className={'grid grid-cols-[400px_400px] gap-8'}>*/}
94+
{/* {!!relatedAdsImages?.length &&*/}
95+
{/* relatedAdsImages.map(({ src, link }, index) => (*/}
96+
{/* <AdExample key={src} src={src} link={link} alt={`Ad Example ${index + 1}`} />*/}
97+
{/* ))}*/}
98+
{/* {!relatedAdsImages?.length && <>No ads detected.</>}*/}
99+
{/* </div>*/}
100+
{/* </CardContent>*/}
101+
{/*</Card>*/}
102102
</div>
103103
);
104104
};

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)