Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't propagate unmount error on windows to UI if verification succeeded. #237

Open
zwhitchcox opened this issue May 26, 2022 · 1 comment

Comments

@zwhitchcox
Copy link
Contributor

zwhitchcox commented May 26, 2022

A lot of users are getting errors that the unmount operation failed:

balena-io/etcher#3542
balena-io/etcher#3730
balena-io/etcher#1370

...etc.

Even though the verification makes it to 100%.

We can see that even if a user has a task manager open, the device can be marked as busy:

balena-io/etcher#1316

Even though nothing has changed, the task manager just has the device open, so it is marked as "busy".

If we make it to 100% verification, the flashing has succeeded, and so there is no need to propagate a failure error to the user, because the user thinks that something has gone wrong with the flashing process.

We should only show the error if the verification has failed.

Ultimately we should try to open the device exclusively so that no other process can have the device open to cause this error, but this is a more difficult problem.

@jellyfish-bot
Copy link

[pipex] This issue has attached support thread https://jel.ly.fish/4ce48cd0-5b76-45f5-a86f-00b4fca21b1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants