Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory exhausted #32

Open
mortenbirkelund opened this issue Jan 8, 2022 · 2 comments
Open

Memory exhausted #32

mortenbirkelund opened this issue Jan 8, 2022 · 2 comments

Comments

@mortenbirkelund
Copy link

Hitting the memory limit when trying to open product_url key report

The file size of the json file is 96mb and the memory limit is 1gb.

Anybody who can clarify why it was decided to store these reports in the filesystem instead of the database?

@hostep
Copy link
Member

hostep commented Jan 10, 2022

Hi @mortenbirkelund

Slightly related issue: #13

Yes, it was a mistake to store the results in json files and not in the database.
There was no good reason for database storage when first writing this module, I never expected people to have soo many problems. But it turns out that certain shops occasionally do have so many problems.

It' on the roadmap to rewrite this storage, but it has been for a while and I didn't find the time or energy for it yet. So don't expect this to be fixed soon, sorry about that!

If you want a quick fix, I would recommend you try to fix as many problems as possible and then to retry it again.

@hostep
Copy link
Member

hostep commented Jan 30, 2022

Hey @mortenbirkelund

I've just released version 1.4.0 of this module, which comes with an option to disable checking problems for invisible products. Reasons for this have been discussed in #31
I think that enabling this option could maybe fix your issue in case you have a lot of invisible products in your shop.

I'm not considering this issue fixed though, we still need to rewrite the storage to use the database instead of json files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants