Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look into including the underlying in the text search #1441

Open
gmbronco opened this issue Jan 9, 2025 · 1 comment
Open

look into including the underlying in the text search #1441

gmbronco opened this issue Jan 9, 2025 · 1 comment
Assignees

Comments

@gmbronco
Copy link
Collaborator

gmbronco commented Jan 9, 2025

No description provided.

@gmbronco
Copy link
Collaborator Author

original message from Bruno:

Hey team :wave::skin-tone-2:
While investigating an issue, I searched for wUSDL in the UI expecting it to return pools with wUSDL.
It missed a [boosted pool](https://balancer.fi/pools/ethereum/v3/0x10a04efba5b880e169920fd4348527c64fb29d4d) where wUSDL is the underlying token
I’m assuming the search algo is considering only pool tokens and not underlying tokens
Can we adapt to also consider the underlying?

this edge case comes from the fact, that FE is using different symbols for displaying purposes and different for adding liquidity to the pool. "wUSDL" is used only for adding liquidity, and search by USDL, or csUSDL – symbols used for displaying finds the pool without any issues.

to include the underlying in the search, we would need to add another join to the pool token for the underlying token, so the whole pools query will becomes slower. Also underlying token can have another underlying token, or pool resulting in even more complexity to cover. My recommendation is to keep things simple and allow to sacrifice searches for hidden information and stick to what is shown in the UI only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant