Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View name collision token_metadata #314

Open
WalterProof opened this issue Jul 24, 2022 · 2 comments
Open

View name collision token_metadata #314

WalterProof opened this issue Jul 24, 2022 · 2 comments
Assignees
Labels
🐛 bug Something isn't working 👋 community Reported or suggested by our awesome users

Comments

@WalterProof
Copy link

This is really an edge case, but

having a view named "token_metadata" make a contract unreadable, crashing with a View name collision token_metadata error

made a simple reproduction there: https://github.com/der-alter/exp-collision

@m-kus m-kus self-assigned this Jul 25, 2022
@droserasprout droserasprout added 🐛 bug Something isn't working 👋 community Reported or suggested by our awesome users labels Sep 14, 2022
@aguillon
Copy link

I'm running into this issue as well with https://packages.ligolang.org/package/ligo-generic-fa2.1 where the collision happens on balance_of, with latest release of PyTezos.

I think a fix would be to not make views accessible from the ContractInterface itself, since they're already available from the .views dict. I can give it a try if that works for you?

@aguillon
Copy link

aguillon commented Jul 2, 2023

My bad, .views has objects of the ViewSection class. I'll change the name in the Ligo library, but changing the behaviour from PyTezos might be nice as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👋 community Reported or suggested by our awesome users
Projects
None yet
Development

No branches or pull requests

4 participants