Cleanup

Author: droserasprout

README.md

@@ -12,13 +12,12 @@
 **pysignalr** is a modern, reliable, and async-ready client for the [SignalR protocol](https://docs.microsoft.com/en-us/aspnet/core/signalr/introduction?view=aspnetcore-5.0). This project started as an asyncio fork of mandrewcito's [signalrcore](https://github.com/mandrewcito/signalrcore) library and ended up as a complete rewrite.
 
 ## Table of Contents
+
 1. [Installation](#installation)
 2. [Basic Usage](#basic-usage)
 3. [Usage with Token Authentication](#usage-with-token-authentication)
 4. [API Reference](#api-reference)
-5. [Roadmap](#roadmap)
-6. [Contributing](#contributing)
-7. [License](#license)
+5. [License](#license)
 
 ## Installation
 

example.py

@@ -2,10 +2,13 @@
 
 import asyncio
 from contextlib import suppress
+from typing import TYPE_CHECKING
 from typing import Any
 
 from pysignalr.client import SignalRClient
-from pysignalr.messages import CompletionMessage
+
+if TYPE_CHECKING:
+    from pysignalr.messages import CompletionMessage
 
 
 async def on_open() -> None:

example_with_token.py

@@ -2,10 +2,13 @@
 
 import asyncio
 from contextlib import suppress
+from typing import TYPE_CHECKING
 from typing import Any
 
 from pysignalr.client import SignalRClient
-from pysignalr.messages import CompletionMessage
+
+if TYPE_CHECKING:
+    from pysignalr.messages import CompletionMessage
 
 
 async def on_open() -> None:

pyproject.toml

@@ -25,7 +25,7 @@ homepage = "https://github.com/baking-bad/pysignalr"
 authors = [
     "Lev Gorodetskii <[email protected]>",
     "mandrewcito <[email protected]>",
-    "Caio Barbieri <[email protected]",
+    "Caio Barbieri <[email protected]>",
 ]
 maintainers = [
     "Lev Gorodetskii <[email protected]>",
@@ -64,11 +64,6 @@ line-length = 120
 target-version = "py38"
 
 [tool.ruff.lint]
-ignore = [
-    "E402",  # module level import not at top of file
-    "E501",  # line too long
-    "TCH001", # breaks our runtime Pydantic magic
-]
 extend-select = ["B", "C4", "FA", "G", "I", "PTH", "Q", "RUF", "TCH", "UP"]
 flake8-quotes = { inline-quotes = "single", multiline-quotes = "double" }
 isort = { force-single-line = true, known-first-party = ["pysignalr"] }
@@ -79,7 +74,10 @@ strict = true
 
 [tool.pytest.ini_options]
 asyncio_mode = "auto"
-log_cli_level = "WARNING"
+log_cli = true
+log_cli_level = "INFO"
+log_cli_format = "%(asctime)s [%(levelname)s] %(message)s"
+log_cli_date_format = "%Y-%m-%d %H:%M:%S"
 
 [tool.coverage.report]
 precision = 2

src/pysignalr/client.py

@@ -3,6 +3,7 @@
 import uuid
 from collections import defaultdict
 from contextlib import asynccontextmanager
+from typing import TYPE_CHECKING
 from typing import Any
 from typing import AsyncIterator
 from typing import Awaitable
@@ -20,14 +21,16 @@
 from pysignalr.messages import PingMessage
 from pysignalr.messages import StreamInvocationMessage
 from pysignalr.messages import StreamItemMessage
-from pysignalr.protocol.abstract import Protocol
 from pysignalr.protocol.json import JSONProtocol
-from pysignalr.transport.abstract import Transport
 from pysignalr.transport.websocket import DEFAULT_CONNECTION_TIMEOUT
 from pysignalr.transport.websocket import DEFAULT_MAX_SIZE
 from pysignalr.transport.websocket import DEFAULT_PING_INTERVAL
 from pysignalr.transport.websocket import WebsocketTransport
 
+if TYPE_CHECKING:
+    from pysignalr.protocol.abstract import Protocol
+    from pysignalr.transport.abstract import Transport
+
 EmptyCallback = Callable[[], Awaitable[None]]
 AnyCallback = Callable[[Any], Awaitable[None]]
 MessageCallback = Callable[[Message], Awaitable[None]]

src/pysignalr/transport/websocket.py

@@ -4,6 +4,7 @@
 import logging
 from contextlib import suppress
 from http import HTTPStatus
+from typing import TYPE_CHECKING
 from typing import Awaitable
 from typing import Callable
 
@@ -20,13 +21,15 @@
 from pysignalr.messages import CompletionMessage
 from pysignalr.messages import Message
 from pysignalr.messages import PingMessage
-from pysignalr.protocol.abstract import Protocol
 from pysignalr.transport.abstract import ConnectionState
 from pysignalr.transport.abstract import Transport
 from pysignalr.utils import get_connection_url
 from pysignalr.utils import get_negotiate_url
 from pysignalr.utils import replace_scheme
 
+if TYPE_CHECKING:
+    from pysignalr.protocol.abstract import Protocol
+
 DEFAULT_MAX_SIZE = 2**20  # 1 MB
 DEFAULT_PING_INTERVAL = 10
 DEFAULT_CONNECTION_TIMEOUT = 10