Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to call this function in order to delete a document #12

Open
todo bot opened this issue Mar 20, 2019 · 2 comments
Open

Remove the need to call this function in order to delete a document #12

todo bot opened this issue Mar 20, 2019 · 2 comments

Comments

@todo
Copy link

todo bot commented Mar 20, 2019

// TODO: Remove the need to call this function in order to delete a document
// Is not necesary create a whole object just to use the id in order to DELETE document. The ID should be set manually
$object->document();
$indexName = static::$indexName ?? self::generateIndexNameFromObject($object);


This issue was generated by todo based on a TODO comment in 97c9816 when #8 was merged. cc @bakaphp.
@todo todo bot added the todo 🗒️ label Mar 20, 2019
@gabbanaesteban
Copy link
Contributor

@kaioken what about this issue? Does it make sense to you?

@kaioken
Copy link
Member

kaioken commented Mar 20, 2019

you can provide the two options, I would prefer to delete based on a actual document similar to a ORM for a db row on any of the frameworks , where you have to find::(id)->delete();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants