Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RNN benchmark to measure backprop wrt params. #99

Merged
merged 4 commits into from
May 25, 2018
Merged

Fix RNN benchmark to measure backprop wrt params. #99

merged 4 commits into from
May 25, 2018

Conversation

sharannarang
Copy link
Contributor

This fixes #87

@sharannarang sharannarang requested a review from mpatwary May 16, 2018 23:25
@sharannarang
Copy link
Contributor Author

@mpatwary , can you look at the changes? I'm working on updating the results spreadsheets but the code can be reviewed for now.

mpatwary
mpatwary approved these changes May 22, 2018
View reviewed changes
Copy link
Collaborator

@mpatwary mpatwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sharannarang
Copy link
Contributor Author

@mpatwary , Thanks for the review. Merging this PR

@sharannarang sharannarang merged commit a5a2b60 into baidu-research:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpatwary mpatwary mpatwary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No BackwardWeights in RNNs
2 participants
@sharannarang @mpatwary