-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wheel/python-version/python-implementation/status badage for PyPI. #465
Conversation
<tr><th data-keywords='python'> PyPI: </th> | ||
<td><img src='https://img.shields.io/pypi/status/Django.svg' alt=''/></td> | ||
<td><code>https://img.shields.io/pypi/status/Django.svg</code></td> | ||
</tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.html
is auto-generated. Apply modifications to try.html instead.
To replace the pypipins: badges/pypipins#39
@espadrine I modified the |
} else if (info == 'implementation') { | ||
var implementations = []; | ||
var pattern = /^Programming Language \:\: Python \:\: Implementation \:\: (\S+)$/; | ||
for (var i in data.info.classifiers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use a regular loop here, please?
for (var i = 0; i < data.info.classifiers.length; i++) {
…
}
(Yes, I agree, JS is ugly compared to Python ☺.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
Thanks a lot for contributing! I hope all is well on @kura's side; even his blog, which I loved, is down. (As a tiny extra, it would be fantastic if you'd use |
<td><code>https://img.shields.io/pypi/wheel/Django.svg</code></td> | ||
</tr> | ||
<tr><th data-keywords='python'> PyPI: </th> | ||
<td><img src='/pypi/py_versions/Django.svg' alt=''/></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using pyversions
above. Which do you prefer?
(I have a personal preference to pyversions
, but I'm not well-versed in the python community.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I forgot it. It will be fixed :-)
@espadrine I pushed new commits. |
10/10 will merge and prod. |
Thank you! |
It's live. Try it, tell me if there is a bug we didn't anticipate; I'll update the website in 24h to invite everyone to use it. |
👍 Okay, I will. |
Hello guys, Thanks for what you've already done, but It seems like _py_versions_ isn't working https://img.shields.io/pypi/py_versions/Django.svg For my project https://img.shields.io/pypi/py_versions/myql.svg Thanks |
@josuebrunel |
@tonyseek thanks a lot. Great job 👍 |
tonyseek@dee58b4 is a temporary commit :-) |
Great work, thanks. |
@xflr6 yes, that would be great! What did it look like? |
Yes, the best available format from |
In my opinion keeping |
Further information on how to detect wheel / egg: https://github.com/kura/yarg/blob/master/yarg/package.py#L241 I have a patch. |
@xflr6 this should work: https://img.shields.io/pypi/format/graphviz.svg As usual, I'll update the website in 24h. |
Great, thanks a lot! As for the color of the version badge, I just realized that mine are red because I conservatively keep my packages in the |
@xflr6 I wish to keep backwards-compatibility with pypip. Can you specify the difference between the current state and pypip? |
Sorry this did not come through: The version badge was green regardless of the version (so a color-overriding parameter would make it possible to make the badge look exactly like before). |
Please review it. Thanks.
Related Issues: badges/pypipins#39 badges/pypipins#37