-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21.0.0 regression: requests to __cypress/tests?p=* hang indefinitely #1243
Comments
Closing as not reproducible. You can open up another ticket when you can provide it. |
Fine with me 👍🏼 I'll dump some more information in this issue while debugging. Looks like the 21.0.0
Then, when pressing Ctrl+C to stop the process, the following is also logged
20.1.2
|
Looks like it's getting stuck in this cypress-cucumber-preprocessor/lib/step-definitions.ts Lines 48 to 52 in 2a3ea39
|
@badeball, apologies for tagging you, but I have a really hard time creating a reproducible example because of the configuration-inside-a-shared-package setup on our side. Does the information in my previous comment ring any bells for you, before I spend a few more hours trying to debug the diff between I also haven't set this up on our side myself so I'm trying to debug in two codebases I don't know much about 😅 |
It should take you no such time to reproduce a folder structure and yes, that is what you should do. |
A reproducible example doesn't involve you diving into this code base. You should just take any of the examples, make the tiniest modification possible so that it reproduces the error, then share that example with me. |
Hi there 👋 , I've faced this issue this morning too, I do not know what is the awaited format of this reproducible example, I've forked this repo and created a PullRequest to emphase the requirements to face the same issue: #1244. Once you've cloned this repo and switch to the PR branch simply:
The infinite loop seems to be reproduced when the config file of cypress is in a nested folder (I do not know why). the difference between the 2 scripts is only the config file location, content of these files is identical. Thanks to @cascornelissen investigation I confirm that in the buggy case scenario the do/while loop is done infinitively. |
I have same issue. but I noticed that just reverting the update for preprocessor did not fix the issue. since I did update cypress from 13.14.2 to 13.15.0 same day, I tried reverting that change as well. and now my tests are back. not sure if it is just |
On my side the buggy case happened on a cypress 13.14.2, but also reproduced here with a 13.5.0 |
I don't want to derail this issue into an off-topic discussion but it feels wrong to me not to reply to this.
I said I didn't want to spend a few more hours of debugging the codebase if you just happened to know what the root cause for this issue was, or could at least point me into some direction. I've tried to create a reproducible example, I failed. I also couldn't test specific commits because installing directly from GitHub doesn't work for this package. Maybe you're right and it shouldn't take me that much time but for someone who doesn't know this project, its codebase, and how its implemented on our side, it was hard to create a setup that reproduces the issue I am facing.
As said, I tried that and failed to create a reproducible example and because of that I took a dive into the codebase, to try and figure out what might be causing it, so that I could provide a reproducible example. Either way, I'm glad I'm not the only one and that there's a reproducible example and that my digging wasn't in vain. Hoping that the fix is easy 🤞🏼 On the off-chance that this will be interpreted the wrong way, and I truly understand where you're coming from as I also manage a few (smaller) npm packages for which issues get created with no information: please also think about the way your messages will be interpreted by others. You have every right to close issues and communicate in the way you want, but please realize that others are also just trying to help out and figure out where things are going wrong. The (online) world is hostile enough as it is already 😞 |
This is fixed with v21.0.1. |
Thanks for the fix, I can confirm it solves the issue on our side as well 🫶 |
Current behavior
Tests are hanging because requests to
__cypress/tests?p=*
are in pending state indefinitely.Desired behavior
Tests don't hang
Test code to reproduce
The only thing we changed was updating to
@badeball/[email protected]
, works as expected with20.1.2
. We're not using the browserify preprocessor or cypress-cucumber-diagnostics mentioned as breaking changes in the release notes.I'll look into a reproducible example and additional logging tomorrow but wanted to report the issue already in case others run into it.
Versions
Checklist
[email protected]
(package name has changed and it is no longer the most recent version, see #689).The text was updated successfully, but these errors were encountered: