Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible types with esbuild 0.21.5 #1198

Closed
3 tasks done
rowleyj opened this issue Jun 10, 2024 · 6 comments
Closed
3 tasks done

Incompatible types with esbuild 0.21.5 #1198

rowleyj opened this issue Jun 10, 2024 · 6 comments

Comments

@rowleyj
Copy link

rowleyj commented Jun 10, 2024

Current behavior


 Property 'with' is missing in type 'import("<PATH>/node_modules/@badeball/cypress-cucumber-preprocessor/node_modules/esbuild/lib/main").OnResolveArgs' but required in type 'import("<PATH>/node_modules/esbuild/lib/main").OnResolveArgs'.
npm ERR! 
npm ERR! 27             plugins: [createEsbuildPlugin(config)],

Desired behavior

Since ^0.21.2 is listed, we expect this package to work with all patch version of esbuild or restrict it to < 0.21.5. Note that this is a brand new version of esbuild.

Test code to reproduce

This is not a functional issue, just a type issue that causes build errors. Setting esbuild to 0.21.3 resolved the issue, but logging as I anticipate others may run into this.

Versions

  • Cypress version: "^13.6.6"
  • Preprocessor version: "^19.2.0"
  • Node version: 18.18.2

Checklist

@badeball
Copy link
Owner

The esbuild-ts example, which uses all latests versions, works seemingly fine. You need to provide a reproducible example to your issue.

@hishchuk
Copy link

Hi!
I have the same issue
image.
It looks there is kind of inconsistency. As a temporary solution I'm adding highlighted line below. Please let me know if more details are needed.
image

@badeball
Copy link
Owner

Please let me know if more details are needed.

Alright - your post doesn't provide any useful information to this issue. If you want to see this issue resolved and contribute to that, you can provide a reproducible example, like OP has been asked of twice now: one in the issue template, twice in the comments.

@hishchuk
Copy link

Hi,

In your example could you please just use attached tsconfig file.
tsconfig.json

Unfortunately I cannot change moduleResolution property, so workaround was used.
I guess this is the main reason of the problem.

Thank you

@badeball
Copy link
Owner

I've updated dependencies, including esbuid, which I believe fixes this, released as v20.0.7. Try it out.

@hishchuk
Copy link

Everything is fine now. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants