build with relative base URL #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapweb was built using / (absolute path) as base URL. However, hard-coding an absolute base path prevents serving snapweb under a different path, e.g. exposing snapweb under `/snapcast/` via a reverse-proxy. To support those kinds of setups, snapweb is built with a relative base URL now.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snapweb was built using the absolute path
/as base URL (default), making asset links absolute. However, hard-coding an absolute base path prevents serving snapweb under a different path, e.g. exposing snapweb under/snapcast/via a reverse-proxy.To support those kinds of setups, snapweb is built with a relative base URL
./now.TL;DR:
In the Makefile-based Snapcast 0.27.0 build I used previously the asset paths were still relative. For me it broke with the update to Snapcast 0.28.0 when using the snapweb v0.7.0 zip distribution explicitly.