Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome(ium) 1 pixel gap between tiles in some map types #19

Open
indigoxela opened this issue Apr 9, 2021 · 8 comments
Open

Chrome(ium) 1 pixel gap between tiles in some map types #19

indigoxela opened this issue Apr 9, 2021 · 8 comments

Comments

@indigoxela
Copy link
Member

Only Chrome and Chromium on some OSes and/or with some special browser settings and only few map types seem affected.
In module leaflet_more_maps it only seems to affect google satellite layers (to be verified, though).

It's a known problem in the 1.x Leaflet library versions, here's their issue: Leaflet/Leaflet#6101
And it probably (?) has to be solved in the browser.

indigoxela added a commit that referenced this issue Apr 9, 2021
@tkcent
Copy link

tkcent commented Apr 9, 2021

Can confirm this fixes the problem for me.

@indigoxela
Copy link
Member Author

@tkcent many thanks for your confirmation.

For others coming here - this is a screenshot of the problem in Chrome:

leaflet-tile-gap-chrome

@lachlanphillips
Copy link

lachlanphillips commented May 25, 2021

There's a really interesting repro you can do that exposes that this issue may be (at least in part) a chrome bug, operating independently of leaflet.

Essentially, you move the map around until you can see the 1px while the map is static. Then go to the leaflet-pane element and toggle the transform: translate3d property on and off.

The 1px line will vanish, move, reappear, all seemingly at random.

Hope this helps someone debug this.

ezgif-1-65b62320b01a

@GeekyMonkey
Copy link

This css nearly works:

img.leaflet-tile {
width: 257px !important;
height: 257px !important;
}

@indigoxela
Copy link
Member Author

indigoxela commented Jan 5, 2022

Hi @GeekyMonkey,

the workaround in this module has been released in April 2021. Are you still experiencing the gap with Backdrop? If so, which map types?

This issue here is just open, because I hoped, that Chrome would fix the browser bug a little sooner (I still hope but switched to "sooner or later" 😉).

As soon as they fixed it, the workaround gets removed again.

@GeekyMonkey
Copy link

GeekyMonkey commented Jan 12, 2022

@indigoxela Apologies. I've reported this in the wrong place. I got here from a google search and saw the project name "leaflet" and thought this was the Leaflet library itself, I didn't realize it was an integration library. Nevermind... :)

@indigoxela
Copy link
Member Author

Seems like this bug will stay for a little longer. But the workaround changed in the meantime. The size hack just had ugly side effects causing "wobbling" images on zoom.

@indigoxela
Copy link
Member Author

indigoxela commented May 18, 2023

Leaflet 1.9.4 is out and it's supposed to provide the bugfix, but...
while mix-blend-mode works fine and fixes the problem in Chrome, it leads to a performance regression in Firefox.

So we adapt our workaround to reset the global (all browser) mix-blend-mode to normal and only set it for chrome-based browsers via css hack. Not ideal, but why punishing FF users for a Chrome bug? 😉

Means: this issue still has to stay open. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants