Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : "Get browser-compatible JavaScript out" Scrollbar Not working #2890

Closed
wants to merge 1 commit into from

Conversation

prajyot004
Copy link

Description

Fixed the issue of horizontal scrolling in homepage mini editor. Horizontal scroll was not working. I have linked the both videos of after and before fix.

Fixes : #2855

Before fix

before.mp4

After fix

after.mp4

Copy link

netlify bot commented May 13, 2024

👷 Deploy request for babel-next pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 603907d

Copy link

netlify bot commented May 13, 2024

Deploy Preview for babel ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 603907d
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/6641e4a300e3a10008cbf856
😎 Deploy Preview https://deploy-preview-2890--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Would it be possible to fix this in a way that makes the scrollbar visible only when it's actually needed?

@prajyot004
Copy link
Author

I'll try to do that

@prajyot004
Copy link
Author

prajyot004 commented May 13, 2024

@nicolo-ribaudo I looked for solution but there are only two ways either we need to keep the output window selectable not editable OR always keep the horizontalscrollbars visible. And on top of it we are keeping the error message window there only we are just change its opacity to 1 when error occurs the place is still occupied by error div so it is making conflicts between scrollbar and error div.
As of now "ace editor" does not provide the property to focus on the scroll bar so there are only two possible solutions.

@JLHwung
Copy link
Contributor

JLHwung commented Nov 18, 2024

Thank you for your PR.

This issue has been fixed in #2750. We enabled the line wrapping for the landing page REPL so there won't be a horizontal scroll bar at all.

@JLHwung JLHwung closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Get browser-compatible JavaScript out" Scrollbar Not working
3 participants