Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.babelrc changes do not bust cache #153

Open
oligriffiths opened this issue Oct 5, 2018 · 5 comments
Open

.babelrc changes do not bust cache #153

oligriffiths opened this issue Oct 5, 2018 · 5 comments

Comments

@oligriffiths
Copy link

When using a .babelrc (or similar) config file for babel, changes to this file to not bust the persistent cache, causing compiled outputs to not change.

Not sure the best way to handle this as https://babeljs.io/docs/en/config-files lists various techniques babel goes through to find config file, but it could be as simple as including their hash in the cache key.

@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2018

Don’t we disable using babelrc files? That is certainly our intent (and definitely worked at one point).

@oligriffiths
Copy link
Author

oligriffiths commented Oct 5, 2018 via email

@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2018

Ahh, ember-cli-babel disabled, not broccoli-babel-transpiler.

@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2018

Should look into how https://babeljs.io/docs/en/config-files#apicache works internally in babel, see if we can leverage the same cache key that they use.

@Turbo87
Copy link
Contributor

Turbo87 commented Oct 5, 2018

to answer your question, ember-cli wants more control over the Babel plugins that get used by default, and using the babelrc file makes that more difficult which is why we disabled it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants