Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate globby options #32

Open
hzoo opened this issue Feb 23, 2018 · 2 comments
Open

Investigate globby options #32

hzoo opened this issue Feb 23, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@hzoo
Copy link
Member

hzoo commented Feb 23, 2018

Ref #31

https://github.com/sindresorhus/globby#gitignore

I think maybe we can just pass this instead of the explicit node_modules check?

@hzoo hzoo added the help wanted Extra attention is needed label Feb 23, 2018
@Raigen
Copy link
Contributor

Raigen commented Feb 24, 2018

I tried it out with different projects, also with https://github.com/Raigen/babel6-tmp.
As long as babel-upgrade does not support monorepos this could be counterproductive for these. The current solution I did for our monorepos is to manually cd into each package inside the monorepo and run babel-upgrade. This updates the .babelrc just fine.
When I replace the explicit node_modules check with the gitignore option it only works from the root of the project. From inside the packages it will again find all package.json files in node_modules and do not update the .babelrc. It seems globby does not lookup the gitignore in parent folders.

I already have a branch with simple monorepo support. I will try out the gitignore option with that branch tomorrow.

@hzoo
Copy link
Member Author

hzoo commented Feb 24, 2018

Yeah we don't have to switch was just wondering if it works, looking forward to the monorepo support +1, you could test it on the babel repo too actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants