Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object literal property has incorrect color in Sublime 4169 #430

Open
simov opened this issue Dec 23, 2023 · 1 comment
Open

Object literal property has incorrect color in Sublime 4169 #430

simov opened this issue Dec 23, 2023 · 1 comment

Comments

@simov
Copy link

simov commented Dec 23, 2023

scope: string.unquoted.js

-     scope: string.unquoted.js
+     scope: string.quoted.js

before
Screenshot from 2023-12-23 11-07-43
after
Screenshot from 2023-12-23 11-07-58

I'm not entirely sure if this is a problem on my end, but the property color of the object literal has always had the color of a string (yellow), and after updating to 4169 it got the color of a keyword (red) instead. Maybe that scope no longer exists or for whatever reason it now defaults to the keyword color, no other changes on my end besides updating Sublime Text.

@deathaxe
Copy link

Syntax definitions provide scopes names to identify tokens. It is common practice to scope JSON/YAML keys meta.mapping.key string for quite some time.

Scope names may change as syntax definitions evolve, which may require adjustments to color schemes to maintain a "got used to" highlighting in some cases.

As mapping keys are correctly scope, this is a "won't fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants