-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol.iterator
should not load full Symbol
polyfill
#80
Comments
Ok so:
Is this correct? |
Btw, I don't think we can always fix the "implicit optional dependency" between those two polyfills: // main.js
import "./dep1.js";
import "./dep2.js"; // dep1.js
Symbol.iterator; // dep2.js
Symbol(); Either we always inject an import to |
@nicolo-ribaudo I mean that |
This comment was marked as off-topic.
This comment was marked as off-topic.
It's another issue. |
Working on this |
@nicolo-ribaudo note that it also requires some other changes, for example, take a look at export default function _createForOfIteratorHelper(o, allowArrayLike) {
var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; that on var $Symbol = typeof Symbol === "function" ? Symbol : {};
var iteratorSymbol = $Symbol.iterator || "@@iterator";
var asyncIteratorSymbol = $Symbol.asyncIterator || "@@asyncIterator";
var toStringTagSymbol = $Symbol.toStringTag || "@@toStringTag"; It's an extended version of something like #199 and changes of some helpers. |
es.symbol
andes.symbol.description
should not be loaded only onSymbol.iterator
- it's too expensive.core-js
architecture should allow to usees.symbol.iterator
and iterators without those modules.The text was updated successfully, but these errors were encountered: