Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Partially done] Add pr-opened label to issues when a pr is opened that fixes/refs the issue #5

Open
hzoo opened this issue Jan 12, 2017 · 6 comments

Comments

@hzoo
Copy link
Member

hzoo commented Jan 12, 2017

why: to make it easy to see which issues already have someone working on them

  • maybe even signal the relevant pr somehow (if active, active x days ago)

name could be different just a suggestion

Parse

  1. just the "fixed tickets" line in our pr template
  2. anything that looks and smells like github ID # and is an issue
  3. (1 || 2) + title of the ticket
@DrewML
Copy link
Member

DrewML commented Jan 12, 2017

Item 1 in the list above is done, but I'm hitting a super weird issue where the sha for the webhook (what we use for the auth) doesn't match what I'm getting for the payload + secret. Haven't had this problem with any other type of events.

@marcoslhc
Copy link

@DrewML Ihad a similar issue sometime ago. IDK if it helps: http://stackoverflow.com/questions/30269030/github-push-event-signature-dont-match

@DrewML
Copy link
Member

DrewML commented Jan 12, 2017

@marcoslhc you rock - thank you! That's probably the issue. Going to give it a shot tonight.

@hzoo
Copy link
Member Author

hzoo commented Jan 14, 2017

Done in a36ba80 already? I already saw it in action lol

screen shot 2017-01-14 at 6 20 34 pm

@DrewML
Copy link
Member

DrewML commented Jan 15, 2017

@hzoo Yeah, I had temporarily disabled signature validation and forgot to re-enable it, lol. Going to put in the fix @marcoslhc recommended now.

@DrewML
Copy link
Member

DrewML commented Jan 15, 2017

Done so far:

  1. just the "fixed tickets" line in our pr template

@hzoo hzoo changed the title Add pr-opened label to issues when a pr is opened that fixes/refs the issue [Partially done] Add pr-opened label to issues when a pr is opened that fixes/refs the issue Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants