Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Labeling PRs with packages touched in the monorepo #1

Open
DrewML opened this issue Jan 7, 2017 · 2 comments
Open

Auto-Labeling PRs with packages touched in the monorepo #1

DrewML opened this issue Jan 7, 2017 · 2 comments
Assignees

Comments

@DrewML
Copy link
Member

DrewML commented Jan 7, 2017

I have a (working) implementation of this done locally, but there are a few decisions we need to make.

  1. Do we have a cutoff (don't label if over X total packages touched)?
  2. Should we not add the label for some use-cases (example: changing only READMEs or package.json)

Input wanted.

@xtuc
Copy link
Member

xtuc commented Jan 8, 2017

Labels:

  • experimental

    • Where packages matches /experimental/
  • flow

    • Where packages matches /flow/
  • cli (new)

    • Where packages matches /^babel-cli$/
  • pkg: register

    • Where package matches /^babel-register$/
  • pkg: traverse

    • Where package matches /^babel-traverse$/
  • pkg: generator

    • Where package matches /^babel-generator$/
  • react

    • Where package matches /react/
  • tag: documentation

    • Where file changed matches /.*\.md$/
    • Where should be at least more than 5 lines changed (I think we don't need to label wording changes).
  • tag: internal

    • Where packages matches /helper/ (if helper are considered as internal)
    • Where package matches /^babel-core/
  • tests

    • Where file changed matches /test\/*.js/ (if helper are considered as internal)

  • Multiples labels could be applied given the rules above.
  • We could limit it to 5 labels.
  • The minium amount of line changed could be set to 5.

@hzoo
Copy link
Member

hzoo commented Mar 15, 2017

Can you push the PR, I think the functionality is what we want and adding the labels later when we want to. An easy one is the react packages -> react or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants