Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: support neil add nrepl -with-cider #199

Open
behrica opened this issue Dec 8, 2023 · 3 comments
Open

suggestion: support neil add nrepl -with-cider #199

behrica opened this issue Dec 8, 2023 · 3 comments

Comments

@behrica
Copy link

behrica commented Dec 8, 2023

this could add

--middleware" "[cider.nrepl/cider-middleware,refactor-nrepl.middleware/wrap-refactor]

and

cider/cider-nrepl {:mvn/version "latest"} + refactor-nrepl/refactor-nrepl {:mvn/version latest}

to the alias ":nrepl"

@borkdude
Copy link
Contributor

borkdude commented Dec 8, 2023

I'm fine with adding this by default, people can remove it if they don't like it.

@teodorlu
Copy link
Contributor

teodorlu commented Jun 7, 2024

@behrica I might take a stab at this—the alias logic has recently changed, making it a bit easier to work with.

Can you help me check whether the following alias entry is what you'd expect?

{:extra-deps
 {nrepl/nrepl {:mvn/version "1.1.2"},
  cider/cider-nrepl {:mvn/version "0.49.0"},
  refactor-nrepl/refactor-nrepl {:mvn/version "3.10.0"}},
 :main-opts
 ["-m" "nrepl.cmdline" "--interactive" "--color"
  "--middleware" "[cider.nrepl/cider-middleware,refactor-nrepl.middleware/wrap-refactor]"]}

@teodorlu
Copy link
Contributor

teodorlu commented Jun 7, 2024

I've got code at #223 that produces the following:

$ neil-dev add nrepl
$ cat deps.edn 
{:deps {}
 :aliases {:nrepl {:extra-deps {nrepl/nrepl {:mvn/version "1.1.2"}, cider/cider-nrepl {:mvn/version "0.49.0"}, refactor-nrepl/refactor-nrepl {:mvn/version "3.10.0"}}
                   :main-opts ["-m" "nrepl.cmdline" "--interactive" "--color" "--middleware" "[cider.nrepl/cider-middleware,refactor-nrepl.middleware/wrap-refactor]"]}}}

I'm not super happy with the super long lines, especially that each key in :extra-deps is on its own line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants