Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on scrollingElement #19

Open
alex7071 opened this issue Jul 13, 2017 · 0 comments
Open

Not working on scrollingElement #19

alex7071 opened this issue Jul 13, 2017 · 0 comments

Comments

@alex7071
Copy link

alex7071 commented Jul 13, 2017

This works fine on any container in the page that has width/height and overflow scroll, but the obvious case in which the scroll is on the document.scrollingElement, it doesn't. Computationally it should be easier, and for older browsers https://github.com/mathiasbynens/document.scrollingElement can be used to have document.scrollingElement available.

LE: Since there are calculation differences between versions of browsers (i.e. Chrome 59 scrollingElement differs from Chrome 61 calculations) using scrollingElement is done only to get the DOM element, viewPort calculations has been changed to use older more reliable measurements which won't change in the predictable future.

alex7071 added a commit to alex7071/react-dnd-scrollzone that referenced this issue Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant