Add renewal functionality #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realnimish
force-pushed
the
feat/add-renewal-feature
branch
from
a4b9817
to
7aa69b7
Compare
wottpal
requested changes
Jul 10, 2024
There was a problem hiding this comment.
- Can you specify the exact cargo-contract & rust versions we're using. I assume both are not the latest as we're not updating to v5 yet.
- → cargo-contract
v3.2.0& rust>v1.69
- → cargo-contract
- Can you provide basic tests for
renew. - Can you do extensive local testing which includes the contract updgrade. E.g.:
- Deploy commit
5a64553locally (current testnet/mainnet deployments afaik) - Do some registrations/etc.
- Upgrade contracts to this branch
- Set new values (i.e.
maxRegistrationDuration,commonPrice) - Do some registrations/renewals/etc.
- Deploy commit
FYI Haven't tested the code myself yet (will do asap).
wottpal
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Updates as discussed:
- Remove max expiry limit
- → no contract changes requires as of now, just the extra tx after upgrade
- Ability to register a new free domain for 1 year whenever the renewal amount exceeds 10 years (hardcoded). Same for registrations with 10+ years.
realnimish
force-pushed
the
feat/add-renewal-feature
branch
from
830c5f8
to
ce04e11
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
realnimish
force-pushed
the
feat/add-renewal-feature
branch
from
4f419ac
to
064a23c
Compare
realnimish
force-pushed
the
feat/add-renewal-feature
branch
from
064a23c
to
6f5a4af
Compare
realnimish
force-pushed
the
feat/add-renewal-feature
branch
from
6f5a4af
to
a3b3312
Compare
…istration period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.