Skip to content
This repository was archived by the owner on Aug 28, 2023. It is now read-only.

Commit 3ca480f

Browse files
committedDec 3, 2019
Update pull request template checklist to include testing the AoT build
It hasn't been a regular part of my process to test the AoT build of the app served through nginx, though we do have the ability to do so. In the past this was somewhat annoying, as the Google API is locked down by referrer, and testing the AoT build would also switch to the production Google API key, which is not (and should not) be set up for local testing. Switching away from the Google Maps API makes local testing of the AoT build easier. We've been bitten enough times by things working in development but not on staging, that I think it is worth the time spent to add this to our checklist.
1 parent 2b7f222 commit 3ca480f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎.github/PULL_REQUEST_TEMPLATE.md

+1
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,6 @@ Optional. Ancillary topics, caveats, alternative strategies that didn't work out
2020
* Include test case, and expected output
2121

2222
- [ ] Is the CHANGELOG.md updated with any relevant additions, changes, fixes or removals following the format of [keepachangelog](https://keepachangelog.com/en/1.0.0/)?
23+
- [ ] Have you tested any front-end changes using the AoT build (`./scripts/update && ./scripts/server --nginx`)?
2324

2425
Closes #XXX

0 commit comments

Comments
 (0)