Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: documentation improvements #1505

Open
13 of 15 tasks
AdeelH opened this issue Oct 18, 2022 · 5 comments
Open
13 of 15 tasks

TODO: documentation improvements #1505

AdeelH opened this issue Oct 18, 2022 · 5 comments

Comments

@AdeelH
Copy link
Collaborator

AdeelH commented Oct 18, 2022

Follow-up to #1501

Major

Minor

@lewfish
Copy link
Contributor

lewfish commented Oct 28, 2022

What do you think about making it so that you can hit a button next to the notebooks in the docs and it will open it in Google Colab? We will have to modify the notebooks to have a preamble section where we install RV and any other necessary setup.

@AdeelH
Copy link
Collaborator Author

AdeelH commented Oct 31, 2022

I like that idea.

Here is an attempt:
0e31373

Result:
https://raster-vision--1506.org.readthedocs.build/en/1506/tutorials/reading_labels.html

@lewfish
Copy link
Contributor

lewfish commented Nov 1, 2022

Looks good!

I noticed that when searching the docs for an argument to a Config class, the page I'm actually looking for is way down in the results. It seems to show links to source code before API docs. Maybe there's a way to specify a search path of sorts.

For example, when searching https://docs.rastervision.io/en/latest/search.html?q=max_windows, I want it to give me this link first https://docs.rastervision.io/en/latest/api_reference/_generated/rastervision.pytorch_learner.learner_config.GeoDataWindowConfig.html

@AdeelH
Copy link
Collaborator Author

AdeelH commented Nov 1, 2022

Interestingly, the built-in sphinx search (which is used in local builds and PR builds) lists the correct result as the top result. But the actual deployed RTD build uses ElasticSearch, which returns different results. There does not seem to be a way to turn it off as far as I can tell, nor is it clear that we would want to.

There does seem to be a configuration option to down-rank certain pages though, which I have now set to down-rank source code pages -- that should move the correct result up a few places. We won't know if it works until the PR is merged though.

@AdeelH
Copy link
Collaborator Author

AdeelH commented Nov 21, 2022

Some graphics that might be useful to include in the docs:

RV-docs-input

RV-docs-train

RV-docs-pred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants