Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer does not resize correctly on mobile devices #126

Open
PReichetanz opened this issue Sep 6, 2024 · 1 comment
Open

Viewer does not resize correctly on mobile devices #126

PReichetanz opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@PReichetanz
Copy link

Describe the bug
When opening a DICOM file on a mobile device, the image is calculated with the initial space for width and height. If there is more space available (e.g. when you collapse the navigation bar or rotate your screen to landscape), the image stays the same (small) size although there is a lot of black space around it.
In landscape mode, reloading the page does help, but the navigation bar is expanded again and consumes space which the image cannot use.

To Reproduce
Steps to reproduce the behavior:

  1. Open a .dcm file on a mobile device or with the responsive mode of the browser.
  2. Use a small device like an iPhone 11 Pro.
  3. Collapse the sidebar.
  4. (Optional, but great evidence): Rotate to landscape.
  5. Problem: The image stays the same size as when the page was loaded.
  6. (Optional, but great evidence): in desktop responsive mode, start with a small / big screen and resize to the opposite big / small screen: the image does not adjust width and height according to the available space.

Expected behavior
The image resizes according to the actual available space, especially when the sidebar is collapsed or the device is rotated.

Screenshots
Start screen in portrait:
Screenshot 2024-09-06 at 16 48 45

Collapsing the sidebar does not resize the image:
Screenshot 2024-09-06 at 16 49 18

Going into landscape doesn't resize the image:
Screenshot 2024-09-06 at 16 49 28

After reloading in landscape, the image has more space:
Screenshot 2024-09-06 at 16 49 44

Client details:

  • OS: MacOs Sonoma 14.6.1
  • Browser: Safari 17.6, Firefox 128.0b9 (64-bit) (on desktop in responsive mode)
  • Device: iPhone SE 2nd, iPhone 12 Pro
Server details

DICOM viewer app version: 2.1.2

Operating system:

Web server:

Database:

PHP version:

Nextcloud version: Nextcloud Hub 8 (29.0.1)

Logs

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@PReichetanz PReichetanz added the bug Something isn't working label Sep 6, 2024
@PReichetanz
Copy link
Author

I think there is the ReactResizeDetector used in the lines of the acanio-viewer which are responsible for this image, but I'm not sure why it is not working properly (or maybe it is and I don't understand it correctly.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant