-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue on Firefox with trackpad #25
Comments
Hi @jankohlbach ! I am not sure when I will be able to incorporate this as a stable fix, so in the meantime, a temporary fix could be something like: new VirtualScroll({
mouseMultiplier: isTrackpad && isFirefox ? 1/3 : 1
}) where Edit: it looks like wheelDetaX/Y are deprecated so I might just remove them altogether. Just need to test a bit. |
Hey @ayamflow, |
Hey @ayamflow , |
hey @jankohlbach, |
@ayamflow |
Yep, I'm on mac. I'm thinking I could expose another param |
as much as I'd like to see more people using firefox, in this case it's a good thing only few people (and even less with trackpad) are using it 😂 |
@jankohlbach you need to scroll in the white area for the jsfiddle to display something 👀 |
@ayamflow I promise you I don't see anything 😂 maybe onwheel doesn't capture the trackpad, but only mousewheel ... |
I think it is because this lib assumes the firefox is slow, and it isn't ¯\_(ツ)_/¯
and here I am, scrolling locomotive demo in firefox on windows to the bottom in a split-second :')
for me those snippets just do not detect a touchpad at all. they probably work on authors hardware only. |
ah no, I take it back - not a firefox issue for me, locomotive demo scrolls super-fast in chromium as well |
I realized this because of using locomotive scroll and thought the issue is there, but they use virtual-scroll and for me it looks like the issue lays in following line:
virtual-scroll/src/index.js
Line 83 in 4763533
Basically, if I'm in Firefox and using a trackpad, the scrolling is way too fast.
if I only use
evt.deltaY = e.deltaY * -1;
instead of
evt.deltaY = e.wheelDeltaY || e.deltaY * -1;
it looks like it's the same behaviour as in chrome again, so maybe somethin inside Firefox changed regarding wheelDeltaY or something
The text was updated successfully, but these errors were encountered: