Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in direction consistency similarity ? #91

Open
benoriol opened this issue Jan 28, 2024 · 1 comment
Open

Error in direction consistency similarity ? #91

benoriol opened this issue Jan 28, 2024 · 1 comment

Comments

@benoriol
Copy link

Hello,

Seems there might be an error in the formulation of your clip direction consistency similarity, according to #28 ?
It is written down as (C(e_i) - C(o_i)) * (C(e_i+1) - C(e_i))

Did you mean to write
(C(o_i+1)) - C(o_i)) * (C(e_i+1) - C(e_i))
or maybe
(C(e_i)) - C(o_i)) * (C(e_i+1) - C(o_i+1))
?

In the previous issue you said it is the first one, but I don't know if that is actually correct? I would really appreciate if you could confirm which one of the two is it.

Thanks!

@viridityzhu
Copy link

I have the same question regarding the clip direction consistency similarity.

You just have to change the inputs to the function when you call it. So if you are doing the directional score, input consecutive frames, and if you are doing similarity score, input the two frames from the separate videos

Originally posted by @ayaanzhaque in #82 (comment)

From this response, the similarity score would be
(C(e_i)) - C(o_i)) * (CT(e_i)) - CT(o_i))

Which is also different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants