chore(*): set clippy unused_trait_names = warn

We have previously tried to import traits anonymously where possible but
enforcing this manually was hard.

Since Rust 1.83 clippy can now enforce this for us.

Signed-off-by: Dave Tucker <[email protected]>

Author: dave-tucker

Cargo.toml

@@ -107,6 +107,9 @@ which = { version = "7.0.0", default-features = false }
 xdpilone = { version = "1.0.5", default-features = false }
 xz2 = { version = "0.1.7", default-features = false }
 
+[workspace.lints.clippy]
+unused_trait_names = "warn"
+
 [workspace.lints.rust]
 unused-extern-crates = "warn"
 

aya-log/src/lib.rs

@@ -736,7 +736,7 @@ fn try_read<T: Pod>(mut buf: &[u8]) -> Result<(T, &[u8], &[u8]), ()> {
 mod test {
     use std::net::IpAddr;
 
-    use aya_log_common::{WriteToBuf, write_record_header};
+    use aya_log_common::{WriteToBuf as _, write_record_header};
     use log::{Level, logger};
 
     use super::*;

aya-obj/src/btf/btf.rs

@@ -7,7 +7,7 @@ use alloc::{
 };
 use core::{ffi::CStr, mem, ptr};
 
-use bytes::BufMut;
+use bytes::BufMut as _;
 use log::debug;
 use object::{Endianness, SectionIndex};
 
@@ -308,7 +308,7 @@ impl Btf {
         path: P,
         endianness: Endianness,
     ) -> Result<Btf, BtfError> {
-        use std::{borrow::ToOwned, fs};
+        use std::{borrow::ToOwned as _, fs};
         let path = path.as_ref();
         Btf::parse(
             &fs::read(path).map_err(|error| BtfError::FileError {

aya-obj/src/btf/info.rs

@@ -1,6 +1,6 @@
 use alloc::{string::String, vec, vec::Vec};
 
-use bytes::BufMut;
+use bytes::BufMut as _;
 use object::Endianness;
 
 use crate::{

aya-obj/src/btf/relocation.rs

@@ -2,7 +2,7 @@ use alloc::{
     borrow::{Cow, ToOwned as _},
     collections::BTreeMap,
     format,
-    string::{String, ToString},
+    string::{String, ToString as _},
     vec,
     vec::Vec,
 };

aya-obj/src/btf/types.rs

@@ -1,6 +1,6 @@
 #![expect(missing_docs)]
 
-use alloc::{string::ToString, vec, vec::Vec};
+use alloc::{string::ToString as _, vec, vec::Vec};
 use core::{fmt::Display, mem, ptr};
 
 use object::Endianness;

aya-obj/src/obj.rs

@@ -1,20 +1,20 @@
 //! Object file loading, parsing, and relocation.
 
 use alloc::{
-    borrow::ToOwned,
+    borrow::ToOwned as _,
     collections::BTreeMap,
     ffi::CString,
-    string::{String, ToString},
+    string::{String, ToString as _},
     vec,
     vec::Vec,
 };
 use core::{ffi::CStr, mem, ptr, slice::from_raw_parts_mut, str::FromStr};
 
 use log::debug;
 use object::{
-    Endianness, ObjectSymbol, ObjectSymbolTable, RelocationTarget, SectionIndex, SectionKind,
-    SymbolKind,
-    read::{Object as ElfObject, ObjectSection, Section as ObjSection},
+    Endianness, ObjectSymbol as _, ObjectSymbolTable as _, RelocationTarget, SectionIndex,
+    SectionKind, SymbolKind,
+    read::{Object as _, ObjectSection as _, Section as ObjSection},
 };
 
 use crate::{

aya-obj/src/relocation.rs

@@ -1,6 +1,6 @@
 //! Program relocation handling.
 
-use alloc::{borrow::ToOwned, collections::BTreeMap, string::String};
+use alloc::{borrow::ToOwned as _, collections::BTreeMap, string::String};
 use core::mem;
 
 use log::debug;
@@ -502,7 +502,7 @@ fn insn_is_call(ins: &bpf_insn) -> bool {
 
 #[cfg(test)]
 mod test {
-    use alloc::{string::ToString, vec, vec::Vec};
+    use alloc::{string::ToString as _, vec, vec::Vec};
 
     use super::*;
     use crate::maps::{BtfMap, LegacyMap};

aya-tool/src/generate.rs

@@ -1,6 +1,6 @@
 use std::{
     fs::{self, File},
-    io::{self, Write},
+    io::{self, Write as _},
     path::{Path, PathBuf},
     process::Command,
     str,

aya/src/maps/perf/perf_event_array.rs

@@ -3,7 +3,7 @@
 //! [`perf`]: https://perf.wiki.kernel.org/index.php/Main_Page.
 use std::{
     borrow::{Borrow, BorrowMut},
-    ops::Deref,
+    ops::Deref as _,
     os::fd::{AsFd, AsRawFd, BorrowedFd, RawFd},
     path::Path,
     sync::Arc,