Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI host name field is broken #746

Open
Metallion opened this issue Oct 8, 2015 · 1 comment
Open

GUI host name field is broken #746

Metallion opened this issue Oct 8, 2015 · 1 comment

Comments

@Metallion
Copy link
Contributor

Problem

In the GUI, the host name field is broken for two reasons.

  • It allows spaces.
  • It doesn't send the host name to the Web API.

When launching an instance like this:

screenshot10

The request parameter in the database become this:

mysql> select request_params from instances where id=5\G                                                                                                                                               
*************************** 1. row ***************************
request_params: ---
cpu_cores: 1
display_name: new-inst
host_name: 
...
1 row in set (0.00 sec)

host_name is empty.

Solution

  • Add validation to the host name field
  • Fix it so the host name does get sent to the Web API.
@Metallion
Copy link
Contributor Author

I worked on it for a bit in this branch. https://github.com/axsh/wakame-vdc/tree/fix-gui-instance-hostname

Since the web api gets a parameter host_name which is empty, I thought that was the correct parameter and focused on getting it filled in. After getting that done, I noticed that the webapi expects hostname without an underscore. https://github.com/axsh/wakame-vdc/blob/develop/dcmgr/lib/dcmgr/endpoints/12.03/instances.rb#L304-L311

Haven't been able to figure out yet how to make Hijiki send it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant