Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: metadata cli parse data #1644

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: metadata cli parse data #1644

merged 1 commit into from
Dec 21, 2023

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Dec 19, 2023

What this PR does / why we need it?

  • Added a parse-data sub-command for the metadata cli.
  • Briefly mention how to deploy metadata cell in README.
  • Remove address from input, derive it in output.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@blckngm blckngm requested a review from a team as a code owner December 19, 2023 10:01
@blckngm blckngm requested review from jjyr and Simon-Tl December 19, 2023 10:01
@Flouse Flouse requested review from wenyuanhust and KaoImin and removed request for jjyr December 19, 2023 10:02
@Flouse Flouse added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit f68e365 Dec 21, 2023
20 of 23 checks passed
@KaoImin KaoImin deleted the metadata-cli branch December 28, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyuanhust wenyuanhust wenyuanhust approved these changes

@Flouse Flouse Flouse approved these changes

@Simon-Tl Simon-Tl Awaiting requested review from Simon-Tl Simon-Tl is a code owner automatically assigned from axonweb3/axon-dev

@KaoImin KaoImin Awaiting requested review from KaoImin

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blckngm @Flouse @wenyuanhust