Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: change some precompile input and output to tuple #1642

Merged
merged 4 commits into from
Dec 19, 2023
Merged

refactor!: change some precompile input and output to tuple #1642

merged 4 commits into from
Dec 19, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Dec 18, 2023 •
edited by Flouse
Loading

What this PR does / why we need it?

This PR change the input type of ckb_mbt_verify and the output type of get_header and get_cell precompile from T to (T, ) which is easy to parse in solidity.

What is the impact of this PR?

References

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@KaoImin KaoImin requested a review from blckngm December 18, 2023 09:53
blckngm
blckngm previously approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@blckngm blckngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also get cell output?

@KaoImin KaoImin marked this pull request as ready for review December 18, 2023 13:12
@KaoImin KaoImin requested a review from a team as a code owner December 18, 2023 13:12
@Flouse Flouse requested review from driftluo and wenyuanhust and removed request for jjyr and ashuralyk December 18, 2023 13:51
@Flouse Flouse added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit 6fe6ac7 Dec 19, 2023
23 checks passed
@Flouse Flouse mentioned this pull request Dec 19, 2023
Merged
3 tasks
Flouse added a commit that referenced this pull request Dec 19, 2023
@Flouse
Sync main to forcerelay-dev branch (#1643)
343f329 
Due to
922fc38,
Hardfork CI will failed in
[forcerelay-dev](https://github.com/axonweb3/axon/tree/forcerelay-dev)
branch.
It's under expectation.

### What is the impact of this PR?

**Breaking Change**

**PR relation**:
- #1642
@Flouse Flouse mentioned this pull request Dec 19, 2023
Merged
3 tasks
@KaoImin KaoImin deleted the change-precompile-io branch December 28, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyuanhust wenyuanhust wenyuanhust approved these changes

@blckngm blckngm blckngm approved these changes

@ashuralyk ashuralyk ashuralyk approved these changes

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KaoImin @ashuralyk @blckngm @wenyuanhust @Flouse