Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract axon-tools, add serialization #1516

Closed
wants to merge 1 commit into from
Closed

feat: extract axon-tools, add serialization #1516

wants to merge 1 commit into from

Conversation

wenyuanhust
Copy link
Contributor

What this PR does / why we need it?

This PR

  • extract forcerelay related stuff into dir devtools/axon-tools
  • add deserialization of Block, Proposal .etc for forcerelay

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

KaoImin
KaoImin previously approved these changes Oct 30, 2023
View reviewed changes
devtools/axon-tools/Cargo.toml Outdated Show resolved Hide resolved
protocol/src/codec/mod.rs Outdated Show resolved Hide resolved
protocol/src/types/block.rs Show resolved Hide resolved
@KaoImin KaoImin self-requested a review October 30, 2023 06:36
@KaoImin KaoImin dismissed their stale review October 30, 2023 06:37

unintended activation

KaoImin
KaoImin suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@KaoImin KaoImin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆 questions should be resolved

@wenyuanhust wenyuanhust marked this pull request as ready for review October 30, 2023 09:12
@wenyuanhust wenyuanhust requested a review from a team as a code owner October 30, 2023 09:12
@wenyuanhust wenyuanhust requested review from sunchengzhu and removed request for a team October 30, 2023 09:12
@Flouse Flouse requested review from ashuralyk and blckngm and removed request for sunchengzhu October 30, 2023 10:12
Flouse
Flouse requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI checks.
image

@wenyuanhust wenyuanhust force-pushed the forcerelay0 branch 3 times, most recently from 1f28c86 to ec9bc1e Compare October 31, 2023 00:49
@wenyuanhust wenyuanhust closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaoImin KaoImin KaoImin requested changes

@Flouse Flouse Flouse requested changes

@ashuralyk ashuralyk Awaiting requested review from ashuralyk

@blckngm blckngm Awaiting requested review from blckngm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenyuanhust @Flouse @KaoImin