Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tx env epoch value #1503

Closed
wants to merge 1 commit into from
Closed

fix: fix tx env epoch value #1503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/interoperation/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ const GAS_TO_CYCLE_COEF: u64 = 6_000;
// The following information is from CKB block [10976708](https://explorer.nervos.org/block/10976708)
// which is CKB2023 disabled.
const CKB2023_DISABLED_NUMBER: u64 = 10_976_708;
const CKB2023_DISABLED_EPOCH: u64 = 0x53c007f0020c8;
// The value must be less than the epoch of the 2023 hardfork and greater than
// the epoch of the 2021 hardfork
const CKB2023_DISABLED_EPOCH: u64 = 0x20c8;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn’t catch your meaning.

Where does CKB2023_DISABLED_NUMBER and CKB2023_DISABLED_EPOCH come from?

References

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10_976_708 this existing block must be activated in 2021 but not activated in 2023

Comment on lines 22 to +27
Copy link
Contributor

@Flouse Flouse Oct 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question

This is the definition for CKB mainnet.
What about CKB testnet?


pub const fn gas_to_cycle(gas: u64) -> u64 {
gas * GAS_TO_CYCLE_COEF
Expand Down
Loading