fix: fix tx env epoch value #1503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
fix-ckb-vm-epoch-value
branch
from
f8dc96e to
ebac470
Compare
driftluo
force-pushed
the
fix-ckb-vm-epoch-value
branch
from
ebac470 to
2c590cc
Compare
KaoImin
approved these changes
Oct 26, 2023
Flouse
requested review from
yangby-cryptape
and removed request for
Simon-Tl
| const CKB2023_DISABLED_EPOCH: u64 = 0x53c007f0020c8; | ||
| // The value must be less than the epoch of the 2023 hardfork and greater than | ||
| // the epoch of the 2021 hardfork | ||
| const CKB2023_DISABLED_EPOCH: u64 = 0x20c8; |
There was a problem hiding this comment.
Sorry, I didn’t catch your meaning.
Where does CKB2023_DISABLED_NUMBER and CKB2023_DISABLED_EPOCH come from?
References
There was a problem hiding this comment.
10_976_708 this existing block must be activated in 2021 but not activated in 2023
Flouse
approved these changes
Oct 30, 2023
Flouse
reviewed
Oct 30, 2023
Comment on lines
22
to
+27
| // The following information is from CKB block [10976708](https://explorer.nervos.org/block/10976708) | ||
| // which is CKB2023 disabled. | ||
| const CKB2023_DISABLED_NUMBER: u64 = 10_976_708; | ||
| const CKB2023_DISABLED_EPOCH: u64 = 0x53c007f0020c8; | ||
| // The value must be less than the epoch of the 2023 hardfork and greater than | ||
| // the epoch of the 2021 hardfork | ||
| const CKB2023_DISABLED_EPOCH: u64 = 0x20c8; |
There was a problem hiding this comment.
Question
This is the definition for CKB mainnet.
What about CKB testnet?
|
Features that will be discarded and do not need to be changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR tx env epoch value
What is the impact of this PR?
No Breaking Change
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description