Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No protection to against DDoS Attack from P2P #1585

Open
yangby-cryptape opened this issue Nov 22, 2023 · 1 comment
Open

No protection to against DDoS Attack from P2P #1585

yangby-cryptape opened this issue Nov 22, 2023 · 1 comment
Assignees
@driftluo
Labels
enhancement New feature or request P-Low Priority

Comments

@yangby-cryptape
Copy link
Collaborator

Description

The node won't be punished which keep sending malformed data through P2P.
@Flouse Flouse added enhancement New feature or request P-Low Priority labels Nov 22, 2023
@Flouse Flouse changed the title No protection to against DDoS Attack No protection to against DDoS Attack from P2P Nov 24, 2023
@Flouse
Copy link
Contributor

Flouse commented Nov 24, 2023

I agree that it's better to have the P2P port protection.

Potential solution: whitelist rule

In reality, there are fewer cases where one would actively want to run a sync-node of an app-chain, which are usually maintained by several trusted validators.

If an app-chain is not completely permissionless, then open p2p port with a whitelist rule is accessible IMO.

So I suggest to postpone this optimization plan. Would like to hear @driftluo 's opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@driftluo driftluo

Labels
enhancement New feature or request P-Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Flouse @driftluo @yangby-cryptape and others