From 2ee2716b1be1e2fed099b1611d9ca1604e5f86f2 Mon Sep 17 00:00:00 2001 From: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Date: Fri, 26 Apr 2024 16:18:15 -0700 Subject: [PATCH] chore: keep old behavior of `EccInstructions::sum_with_const` After https://github.com/axiom-crypto/halo2-lib/pull/244 the `EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming to still use the `sum_unsafe` function so that snark verifier circuits do not change. --- Cargo.lock | 4 ++++ snark-verifier/src/loader/halo2/shim.rs | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Cargo.lock b/Cargo.lock index b474c81a..1f1a2211 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1127,6 +1127,8 @@ dependencies = [ [[package]] name = "halo2-axiom" version = "0.4.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "d698920cd4cb189e6b90db50cb9393f1671f732f39665b907f745b5d45b51c8c" dependencies = [ "blake2b_simd", "crossbeam", @@ -1146,6 +1148,7 @@ dependencies = [ [[package]] name = "halo2-base" version = "0.4.2-alpha.0" +source = "git+https://github.com/axiom-crypto/halo2-lib.git?branch=develop#d23968cd00a0a0bbfe78f8bdaa83107749c51d85" dependencies = [ "getset", "halo2-axiom", @@ -1167,6 +1170,7 @@ dependencies = [ [[package]] name = "halo2-ecc" version = "0.4.1" +source = "git+https://github.com/axiom-crypto/halo2-lib.git?branch=develop#d23968cd00a0a0bbfe78f8bdaa83107749c51d85" dependencies = [ "halo2-base", "itertools 0.11.0", diff --git a/snark-verifier/src/loader/halo2/shim.rs b/snark-verifier/src/loader/halo2/shim.rs index b79145f1..74b79bfc 100644 --- a/snark-verifier/src/loader/halo2/shim.rs +++ b/snark-verifier/src/loader/halo2/shim.rs @@ -291,7 +291,7 @@ mod halo2_lib { let constant = EccInstructions::assign_constant(self, ctx, constant); Some(constant) }; - self.sum::( + self.sum_unsafe::( ctx.main(), constant.into_iter().chain(values.iter().map(|v| v.deref().clone())), )